Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path handling on Windows #687

Closed
wants to merge 36 commits into from

Conversation

lvcabral
Copy link
Contributor

Several unit tests were failing due to the bad handling of non-posix paths (Windows).

TwitchBronBron and others added 30 commits April 19, 2023 10:49
refactor in preparation for adoption the project
…ot-compliant

Fixed `val()` edge cases: hex without radix and `NaN`
* add logic for optional chaining

* remove console log

* format doc

* fix test

* fix uts
* Preventing multiple calls for dot-chained methods

* Fixed `prettier` issue
…d `roTimespan` #28 (#29)

* fix(components): Replacing package luxon by day.js on `roDateTime` and `roTimespan` #28

* Fixed prettier issue
…nd `roAssociativeArray` (#33)

* Implements missing methods from `ifEnum` in `roArray` and `roAssociativeArray` #26

* Implemented unit tests

* Prettier fix

---------

Co-authored-by: Bronley Plumb <[email protected]>
* feat(lex): Emit try/catch/throw lexemes for parsing

RBI 9.4 adds support for error handling via the `try`/`catch` model [1].
Interestingly, `try`, `catch`, and `endtry` are all valid identifiers!
That makes parsing a little bit tougher, but it's not unprecedented in
this language.  Detect `try`/`catch`/throw`/`end try` during lexing and
emit the proper lexemes.

[1] https://developer.roku.com/docs/references/brightscript/language/error-handling.html
see sjbarag#554

* feat(parse): Consume try, catch, and end try lexemes

Throwing exceptions and catching them aren't yet supported in `brs`, so
executing only the `try` block seems to be a reasonable "bare minimum"
approach to try/catch support.  Handle `try`, `catch`, and `end try`
lexemes in the parser, emitting TryCatch statements for the interpreter
to execute naïvely.

see sjbarag#554

* Fixed Test Case

---------

Co-authored-by: Sean Barag <[email protected]>
Co-authored-by: Bronley Plumb <[email protected]>
* Adds create-package CI build for quicker iteration

* fix illegal URL chars in name

* use - instead of _

* better release title
* fix(lib): Component XML path parsing was failing on edge case

* Fixed search string to match what `fast-glob` supports
lvcabral and others added 6 commits December 11, 2023 08:50
…()` are not properly boxing parameters (#42)
…th()` (#44)

* Fixed # 43 - Implemented `roString` methods `startsWith()` and `endsWith()`

* Fixed test code formatting
@lvcabral lvcabral closed this Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants